Skip to content

[marshal] Remove Parent by Digest#3843

Merged
clabby merged 2 commits into
cl/restore-marshal-symmetryfrom
remove-subscribe-by-digest
May 20, 2026
Merged

[marshal] Remove Parent by Digest#3843
clabby merged 2 commits into
cl/restore-marshal-symmetryfrom
remove-subscribe-by-digest

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 2eef193 May 20 2026, 03:40 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 20, 2026

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2eef193
Status: ✅  Deploy successful!
Preview URL: https://49fc6193.monorepo-eu0.pages.dev
Branch Preview URL: https://remove-subscribe-by-digest.monorepo-eu0.pages.dev

View logs

@clabby clabby merged commit afc6910 into cl/restore-marshal-symmetry May 20, 2026
10 checks passed
@clabby clabby deleted the remove-subscribe-by-digest branch May 20, 2026 15:40
@github-actions
Copy link
Copy Markdown

Benchmark results

Caution

1 benchmark(s) exceeded the regression threshold.

gandalf
Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.567 ms 1.827 ms +16.63% 10.00% ❌ FAIL regression
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.100 ms 3.119 ms +0.62% 10.00% ✅ PASS

Baseline commit(s): 14a016a55f43

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.74%. Comparing base (02ecfe1) to head (2eef193).
⚠️ Report is 2 commits behind head on cl/restore-marshal-symmetry.

@@                       Coverage Diff                       @@
##           cl/restore-marshal-symmetry    #3843      +/-   ##
===============================================================
+ Coverage                        95.73%   95.74%   +0.01%     
===============================================================
  Files                              473      473              
  Lines                           192572   192472     -100     
  Branches                          4666     4665       -1     
===============================================================
- Hits                            184354   184279      -75     
+ Misses                            6645     6624      -21     
+ Partials                          1573     1569       -4     
Files with missing lines Coverage Δ
consensus/src/marshal/ancestry.rs 94.59% <100.00%> (-0.28%) ⬇️
consensus/src/marshal/coding/mod.rs 96.15% <100.00%> (ø)
consensus/src/marshal/coding/variant.rs 95.08% <100.00%> (+8.51%) ⬆️
consensus/src/marshal/standard/mod.rs 96.80% <100.00%> (ø)
consensus/src/marshal/standard/variant.rs 100.00% <100.00%> (+9.43%) ⬆️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ecfe1...2eef193. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants